# HG changeset patch
# User Tuomo Valkonen <tuomov@iki.fi>
# Date 1735234553 18000
# Node ID e5fab0125a8e758127688fd537053d802d93160c
# Parent  c5f70e76751139511c3d501caf4f6220bf4eb5cb
Move Sum to operator_arithmetic as MappingSum

diff -r c5f70e767511 -r e5fab0125a8e src/mapping.rs
--- a/src/mapping.rs	Tue Dec 31 08:48:50 2024 -0500
+++ b/src/mapping.rs	Thu Dec 26 12:35:53 2024 -0500
@@ -127,53 +127,6 @@
     }
 }
 
-/// A sum of [`Mapping`]s.
-#[derive(Serialize, Debug, Clone)]
-pub struct Sum<Domain, M> {
-    components : Vec<M>,
-    _domain : PhantomData<Domain>,
-}
-
-impl<Domain, M> Sum<Domain, M> {
-    /// Construct from an iterator.
-    pub fn new<I : Iterator<Item = M>>(iter : I) -> Self {
-        Sum { components : iter.collect(), _domain : PhantomData }
-    }
-
-    /// Iterate over the component functions of the sum
-    pub fn iter(&self) -> std::slice::Iter<'_, M> {
-        self.components.iter()
-    }
-}
-
-
-impl<Domain, M> Mapping<Domain> for Sum<Domain, M>
-where
-    Domain : Space + Clone,
-    M : Mapping<Domain>,
-    M::Codomain : std::iter::Sum + Clone
-{
-    type Codomain = M::Codomain;
-
-    fn apply<I : Instance<Domain>>(&self, x : I) -> Self::Codomain {
-        let xr = x.ref_instance();
-        self.components.iter().map(|c| c.apply(xr)).sum()
-    }
-}
-
-impl<Domain, M> DifferentiableImpl<Domain> for Sum<Domain, M>
-where
-    Domain : Space + Clone,
-    M : DifferentiableMapping<Domain>,
-    M :: DerivativeDomain : std::iter::Sum
-{
-    type Derivative = M::DerivativeDomain;
-
-    fn differential_impl<I : Instance<Domain>>(&self, x : I) -> Self::Derivative {
-        let xr = x.ref_instance();
-        self.components.iter().map(|c| c.differential(xr)).sum()
-    }
-}
 
 /// Container for the differential [`Mapping`] of a [`Differentiable`] mapping.
 pub struct Differential<'a, X, G : Clone> {
diff -r c5f70e767511 -r e5fab0125a8e src/operator_arithmetic.rs
--- a/src/operator_arithmetic.rs	Tue Dec 31 08:48:50 2024 -0500
+++ b/src/operator_arithmetic.rs	Thu Dec 26 12:35:53 2024 -0500
@@ -31,6 +31,16 @@
     pub base_fn : T,
 }
 
+impl<T, C> Weighted<T, C>
+where
+    C : Constant,
+{
+    /// Construct from an iterator.
+    pub fn new(weight : C, base_fn : T) -> Self {
+        Weighted{ weight, base_fn }
+    }
+}
+
 impl<'a, T, V, D, F, C> Mapping<D> for Weighted<T, C>
 where
     F : Float,
@@ -62,3 +72,47 @@
         self.base_fn.differential(x) * self.weight.value()
     }
 }
+
+/// A sum of [`Mapping`]s.
+#[derive(Serialize, Debug, Clone)]
+pub struct MappingSum<M>(Vec<M>);
+
+impl< M> MappingSum<M> {
+    /// Construct from an iterator.
+    pub fn new<I : IntoIterator<Item = M>>(iter : I) -> Self {
+        MappingSum(iter.into_iter().collect())
+    }
+
+    /// Iterate over the component functions of the sum
+    pub fn iter(&self) -> std::slice::Iter<'_, M> {
+        self.0.iter()
+    }
+}
+
+impl<Domain, M> Mapping<Domain> for MappingSum<M>
+where
+    Domain : Space + Clone,
+    M : Mapping<Domain>,
+    M::Codomain : std::iter::Sum + Clone
+{
+    type Codomain = M::Codomain;
+
+    fn apply<I : Instance<Domain>>(&self, x : I) -> Self::Codomain {
+        let xr = x.ref_instance();
+        self.0.iter().map(|c| c.apply(xr)).sum()
+    }
+}
+
+impl<Domain, M> DifferentiableImpl<Domain> for MappingSum< M>
+where
+    Domain : Space + Clone,
+    M : DifferentiableMapping<Domain>,
+    M :: DerivativeDomain : std::iter::Sum
+{
+    type Derivative = M::DerivativeDomain;
+
+    fn differential_impl<I : Instance<Domain>>(&self, x : I) -> Self::Derivative {
+        let xr = x.ref_instance();
+        self.0.iter().map(|c| c.differential(xr)).sum()
+    }
+}